Skip to content

Temporarily disable rustfmt integration test #5461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 13, 2020
Merged

Temporarily disable rustfmt integration test #5461

merged 2 commits into from
Apr 13, 2020

Conversation

phansch
Copy link
Contributor

@phansch phansch commented Apr 13, 2020 •
edited
Loading

Running rustfmt from master is currently broken and fails our bors build:
rust-lang/rust#71077

changelog: none

@phansch
Temporarily disable rustfmt integration test
8ad1d78 
Running rustfmt from master is currently broken:
rust-lang/rust#71077
@phansch phansch added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 13, 2020
@matthiaskrgr
Copy link
Member

Hmm, we clone the rustfmt repo and run clippy on it to see if clippy crashes, right?
I think the test should just fail on just on clippy panics/ ICEs and not on "compiler errors" as it might be the case here?

@phansch
Copy link
Contributor Author

phansch commented Apr 13, 2020

Hmm, we clone the rustfmt repo and run clippy on it to see if clippy crashes, right?
I think the test should just fail on just on clippy panics/ ICEs and not on "compiler errors" as it might be the case here?

Yeah, I was thinking the same, but we have an explicit panic for this here?

rust-clippy/tests/integration.rs

Line 67 in e29d550

panic!("error: E0463");

@phansch
Copy link
Contributor Author

phansch commented Apr 13, 2020 •
edited
Loading

Ah, looks like we added this in #3552 because the E0463 error was not causing the build to fail.

@matthiaskrgr
Copy link
Member

Ah ok.
r=me with a code comment why we match on this error code then :)

@phansch
Copy link
Contributor Author

phansch commented Apr 13, 2020

@bors r=matthiaskrgr

@bors
Copy link
Contributor

bors commented Apr 13, 2020

📌 Commit a4deb5a has been approved by matthiaskrgr

@bors
Copy link
Contributor

bors commented Apr 13, 2020

⌛ Testing commit a4deb5a with merge 6d4cc56...

@bors
Copy link
Contributor

bors commented Apr 13, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: matthiaskrgr
Pushing 6d4cc56 to master...

@bors bors merged commit 6d4cc56 into rust-lang:master Apr 13, 2020
@phansch phansch deleted the disable_rustfmt_integration_test branch April 13, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phansch @matthiaskrgr @bors